refactor: use pre-built protoc binary#248
Merged
EdSchouten merged 8 commits intobuildbarn:masterfrom Jun 10, 2025
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saves a bunch of time in analysis and execution when there is a cache miss on protoc, as well as avoiding a bunch of gcc logspam.
For example a recent commit on master took 3m 54s to
Run
bazel run @com_github_bazelbuild_buildtools//:buildifierhttps://github.com/buildbarn/bb-storage/actions/runs/15302599382/job/43046869873
and printed 256 lines of log output such as
Nearly all the time and log output is attributed to compiling
cc_binary @protobuf//:protoc